lkml.org 
[lkml]   [2015]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 5/7] vfio: fix a problematic usage of WARN()
    From
    Date
    On Wed, 2015-11-25 at 21:12 +0800, Geliang Tang wrote:
    > WARN() takes a condition and a format string. The condition was
    > omitted. So I added it.
    >
    > Signed-off-by: Geliang Tang <geliangtang@163.com>
    > ---
    > drivers/vfio/vfio.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
    > index de632da..9da0703 100644
    > --- a/drivers/vfio/vfio.c
    > +++ b/drivers/vfio/vfio.c
    > @@ -682,7 +682,7 @@ static int vfio_group_nb_add_dev(struct vfio_group *group, struct device *dev)
    > return 0;
    >
    > /* TODO Prevent device auto probing */
    > - WARN("Device %s added to live group %d!\n", dev_name(dev),
    > + WARN(1, "Device %s added to live group %d!\n", dev_name(dev),
    > iommu_group_id(group->iommu_group));
    >
    > return 0;

    This was already reported and I've got a patch queued to resolve it:

    https://www.mail-archive.com/kvm@vger.kernel.org/msg123061.html

    Thanks,

    Alex



    \
     
     \ /
      Last update: 2015-11-25 15:01    [W:7.537 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site