lkml.org 
[lkml]   [2015]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] ixp4xx_eth: Delete an unnecessary check before the function call "dma_pool_destroy"
    Date
    SF Markus Elfring <elfring@users.sourceforge.net> writes:

    > The dma_pool_destroy() function tests whether its argument is NULL
    > and then returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.

    > --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
    > +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
    > @@ -1192,7 +1192,7 @@ static void destroy_queues(struct port *port)
    > port->desc_tab = NULL;
    > }
    >
    > - if (!ports_open && dma_pool) {
    > + if (!ports_open) {
    > dma_pool_destroy(dma_pool);
    > dma_pool = NULL;
    > }

    Acked-by: Krzysztof Halasa <khalasa@piap.pl>
    --
    Krzysztof Halasa

    Industrial Research Institute for Automation and Measurements PIAP
    Al. Jerozolimskie 202, 02-486 Warsaw, Poland


    \
     
     \ /
      Last update: 2015-11-25 13:41    [W:4.031 / U:1.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site