Messages in this thread | | | From | (Krzysztof Hałasa) | Subject | Re: [PATCH] ixp4xx_eth: Delete an unnecessary check before the function call "dma_pool_destroy" | Date | Wed, 25 Nov 2015 13:19:12 +0100 |
| |
SF Markus Elfring <elfring@users.sourceforge.net> writes:
> The dma_pool_destroy() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software.
> --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c > +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c > @@ -1192,7 +1192,7 @@ static void destroy_queues(struct port *port) > port->desc_tab = NULL; > } > > - if (!ports_open && dma_pool) { > + if (!ports_open) { > dma_pool_destroy(dma_pool); > dma_pool = NULL; > }
Acked-by: Krzysztof Halasa <khalasa@piap.pl> -- Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland
| |