lkml.org 
[lkml]   [2015]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] block: kmemleak: Track the page allocations for struct request
Hi Jens,

On Mon, Sep 14, 2015 at 7:21 PM, Jens Axboe <axboe@kernel.dk> wrote:
> On 09/14/2015 11:16 AM, Catalin Marinas wrote:
>>
>> The pages allocated for struct request contain pointers to other slab
>> allocations (via ops->init_request). Since kmemleak does not track/scan
>> page allocations, the slab objects will be reported as leaks (false
>> positives). This patch adds kmemleak callbacks to allow tracking of such
>> pages.
>>
>> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
>> Reported-by: Bart Van Assche <bart.vanassche@sandisk.com>
>> Tested-by: Bart Van Assche<bart.vanassche@sandisk.com>
>> Cc: Christoph Hellwig <hch@infradead.org>
>> Cc: Jens Axboe <axboe@kernel.dk>
>> ---
>>
>> Jens,
>>
>> I just realised that no-one has picked this patch up for -rc1. It was
>> discussed here previously:
>>
>>
>> http://lkml.kernel.org/r/20150803104309.GB4033@e104818-lin.cambridge.arm.com
>>
>> Since it touches the block layer, are you fine with merging it?
>
>
> Yeah looks simple enough for me, not sure why it got missed. I'll add it for
> 4.4-rc1, thanks.

I saw the related kmemleaks reports on my v4.1.x kernel. Since it's
actually fixing these wrong reports, do you think it could be a good
candidate for -stable tree?

Thanks,
--
William


\
 
 \ /
  Last update: 2015-11-25 12:21    [W:0.248 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site