lkml.org 
[lkml]   [2015]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: net: Generalise wq_has_sleeper helper
From
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 24 Nov 2015 13:54:23 +0800

> On Wed, Nov 11, 2015 at 05:48:29PM +0800, Herbert Xu wrote:
>>
>> BTW, the networking folks found this years ago and even added
>> helpers to deal with this. See for example wq_has_sleeper in
>> include/net/sock.h. It would be good if we can move some of
>> those helpers into wait.h instead.
>
> Here is a patch against net-next which makes the wq_has_sleeper
> helper available to non-next users:
>
> ---8<---
> The memory barrier in the helper wq_has_sleeper is needed by just
> about every user of waitqueue_active. This patch generalises it
> by making it take a wait_queue_head_t directly. The existing
> helper is renamed to skwq_has_sleeper.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

I'm fine with wherever this patch goes. Herbert is there any
particular tree where it'll facilitate another user quickest?

Or should I just toss it into net-next?

Acked-by: David S. Miller <davem@davemloft.net>


\
 
 \ /
  Last update: 2015-11-24 23:01    [W:0.121 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site