lkml.org 
[lkml]   [2015]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V4] acpi: add support for extended IRQ to PCI link
From
Date
On 11/24/2015 1:11 PM, Bjorn Helgaas wrote:
>
> As Andy mentioned, please wrap this text to use more of an 80-column
> line. I fill changelogs to 75 columns (vi textwidth=75), which fits
> perfectly when "git log" inserts 4 leading spaces.
>

will do

>
> These changes are basically all bounds-checking link->irq.possible[i]
> and link->irq.active. What if you put that checking at the point
> where we *initialize* those fields instead, i.e., in
> acpi_pci_link_check_possible() and acpi_pci_link_get_current()? Then
> you'd only have to check each field in one place, and you could easily
> add a message if we see an ID that's too large.
>

I'll post a patch soon.

> I think the current code for ACPI_RESOURCE_TYPE_EXTENDED_IRQ is buggy
> because it silently truncates IDs to 8 bits.
>
> Bjorn
>


--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project


\
 
 \ /
  Last update: 2015-11-24 21:21    [W:0.999 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site