Messages in this thread | | | Date | Tue, 24 Nov 2015 19:33:49 +0100 | From | Alban <> | Subject | Re: [PATCH] reset: ath79: Add system restart support |
| |
On Tue, 24 Nov 2015 13:01:46 +0100 Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Hi Alban, > > Am Dienstag, den 24.11.2015, 01:00 +0100 schrieb Alban Bedel: > > Add a system restart handler that use the FULL_CHIP_RESET bit of the > > reset controller. > > > > Signed-off-by: Alban Bedel <albeu@free.fr> > > Applied, thanks.
Thanks to you :)
> Btw, should this driver #include <linux/io.h> for readl/writel?
Good question :) It turns out to be a MIPS glitch, asm/io.h is included by asm/page.h which here come from linux/module.h. But we shouldn't rely on this glitch and the driver should #include <linux/io.h>. I'll fix this and add support for CONFIG_COMPILE_TEST to better catch this kind of bugs in the future.
Alban
| |