lkml.org 
[lkml]   [2015]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] video: omapdss: delete unneeded of_node_put
From
Date


On 12/10/15 23:43, Julia Lawall wrote:
> Device node iterators perform an of_node_put on each iteration, so putting
> an of_node_put before a continue results in a double put.
>
> A simplified version of the semantic match that finds this problem is as
> follows (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> iterator i;
> @@
>
> i(..., child, ...) {
> ... when != of_node_get(child)
> * of_node_put(child);
> ...
> * continue;
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/video/fbdev/omap2/dss/omapdss-boot-init.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Thanks, queued for 4.5.

Tomi

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-11-24 13:01    [W:0.048 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site