lkml.org 
[lkml]   [2015]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/2] arcmsr: adds code for support areca new adapter ARC1203
    From
    Date
    On Tue, 2015-11-24 at 01:33 -0800, Joe Perches wrote:
    > On Tue, 2015-11-24 at 16:17 +0800, Ching Huang wrote:
    > > From: Ching Huang <ching2048@areca.com.tw>
    > >
    > > Support areca new PCIe to SATA RAID adapter ARC1203
    >
    > Why add the dma_free_coherent to an old data path?
    > Is that a general bug fix that should be backported?

    That's right. It's need to release the allocated resource for failed condition.
    >
    > btw: the printk above the dma_free_coherent use
    > shouldn't use a \ line continuation.
    > it adds undesired whitespace to the format.
    >
    > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
    > []
    > > @@ -2660,10 +2670,19 @@ static bool arcmsr_hbaB_get_config(struc
    > > iop_firm_version = (char __iomem *)(®->message_rwbuffer[17]);> > /*firm_version,17,68-83*/
    > > iop_device_map = (char __iomem *)(®->message_rwbuffer[21]);> > /*firm_version,21,84-99*/
    > >
    > > + arcmsr_wait_firmware_ready(acb);
    > > + writel(ARCMSR_MESSAGE_START_DRIVER_MODE, reg->drv2iop_doorbell);
    > > + if (!arcmsr_hbaB_wait_msgint_ready(acb)) {
    > > + printk(KERN_ERR "arcmsr%d: can't set driver mode.\n", acb->host->host_no);
    > > + goto gcfg1;
    > > + }
    > > writel(ARCMSR_MESSAGE_GET_CONFIG, reg->drv2iop_doorbell);
    > > if (!arcmsr_hbaB_wait_msgint_ready(acb)) {
    > > printk(KERN_NOTICE "arcmsr%d: wait 'get adapter firmware \
    > > miscellaneous data' timeout \n", acb->host->host_no);
    > > +gcfg1:
    > > + dma_free_coherent(&acb->pdev->dev, acb->roundup_ccbsize,
    > > + acb->dma_coherent2, acb->dma_coherent_handle2);
    > > return false;
    > > }
    > > count = 8;
    >




    \
     
     \ /
      Last update: 2015-11-24 11:21    [W:5.664 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site