Messages in this thread | | | Date | Tue, 24 Nov 2015 18:23:26 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH -mm v2] mm: add page_check_address_transhuge helper |
| |
On (11/24/15 11:09), Kirill A. Shutemov wrote: [..] > diff --git a/mm/page_idle.c b/mm/page_idle.c > index 374931f32ebc..4ea9c4ef5146 100644 > --- a/mm/page_idle.c > +++ b/mm/page_idle.c > @@ -66,8 +66,12 @@ static int page_idle_clear_pte_refs_one(struct page *page, > if (pte) { > referenced = ptep_clear_young_notify(vma, addr, pte); > pte_unmap(pte); > - } else > + } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { > referenced = pmdp_clear_young_notify(vma, addr, pmd); > + } else { > + /* unexpected pmd-mapped page? */ > + WARN_ON_ONCE(1); > + } > > spin_unlock(ptl); > > diff --git a/mm/rmap.c b/mm/rmap.c > index 27916086ac50..499b24511b1f 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -929,9 +929,12 @@ static int page_referenced_one(struct page *page, struct vm_area_struct *vma, > referenced++; > } > pte_unmap(pte); > - } else { > + } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { > if (pmdp_clear_flush_young_notify(vma, address, pmd)) > referenced++; > + } else { > + /* unexpected pmd-mapped page? */ > + WARN_ON_ONCE(1); > } > spin_unlock(ptl);
yes, works for me.
-ss
| |