Messages in this thread | | | From | Rasmus Villemoes <> | Subject | Re: [PATCH v1 3/7] test_hexdump: go through all possible lengths of buffer | Date | Mon, 23 Nov 2015 09:59:40 +0100 |
| |
On Fri, Nov 20 2015, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Thu, 2015-11-19 at 11:07 +0100, Rasmus Villemoes wrote: >> >> >> Why keep the variable l when it is just a synonym for the new >> parameter buflen? It is quite confusing that you change some but not >> all occurrences of l to buflen. If you want to make the diff minimal >> but still have a descriptive parameter name, just keep the 'size_t l >> = >> buflen;' assignment and don't otherwise refer to buflen. But I think >> it's better to eliminate 'l' and just change everything to >> buflen. Don't mix the two approaches, though. > > Okay, I got it for the future, though the series is already in linux- > next, so do we really need to re-hack half of it because of that?
Stuff in -next isn't set in stone. I'm pretty sure Andrew can replace one set of patches with another.
Rasmus
| |