| Date | Mon, 23 Nov 2015 17:27:03 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH v3 07/22] kthread: Detect when a kthread work is used by more workers |
| |
Hello,
On Wed, Nov 18, 2015 at 02:25:12PM +0100, Petr Mladek wrote: > @@ -610,6 +625,12 @@ repeat: > if (work) { > __set_current_state(TASK_RUNNING); > work->func(work); > + > + spin_lock_irq(&worker->lock); > + /* Allow to queue the work into another worker */ > + if (!kthread_work_pending(work)) > + work->worker = NULL; > + spin_unlock_irq(&worker->lock);
Doesn't this mean that the work item can't be freed from its callback? That pattern tends to happen regularly.
Thanks.
-- tejun
|