lkml.org 
[lkml]   [2015]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 07/22] kthread: Detect when a kthread work is used by more workers
Hello,

On Wed, Nov 18, 2015 at 02:25:12PM +0100, Petr Mladek wrote:
> @@ -610,6 +625,12 @@ repeat:
> if (work) {
> __set_current_state(TASK_RUNNING);
> work->func(work);
> +
> + spin_lock_irq(&worker->lock);
> + /* Allow to queue the work into another worker */
> + if (!kthread_work_pending(work))
> + work->worker = NULL;
> + spin_unlock_irq(&worker->lock);

Doesn't this mean that the work item can't be freed from its callback?
That pattern tends to happen regularly.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2015-11-23 23:41    [W:0.351 / U:0.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site