Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match | Date | Mon, 23 Nov 2015 17:35:56 +0000 |
| |
From: Florian Westphal > Sent: 21 November 2015 16:56 > > +struct xt_cgroup_info_v1 { > > + __u8 has_path; > > + __u8 has_classid; > > + __u8 invert_path; > > + __u8 invert_classid; > > + char path[PATH_MAX]; > > + __u32 classid; > > + > > + /* kernel internal data */ > > + void *priv __attribute__((aligned(8))); > > +}; > > Ahem. Am I reading this right? This struct is > 4k in size? > If so -- Ugh. Does sizeof(path) really have to be PATH_MAX?
I've not looked at the use, but could you put 'char path[];' as the last member an require any allocations to be long enough to contain the actual path?
David
| |