Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module | Date | Mon, 23 Nov 2015 17:57:28 +0100 |
| |
On Monday 23 November 2015 10:53:51 Andrew F. Davis wrote: > Separate out I2C functionality into a module. This fixes several small > issues and simplifies the driver initialization. > > Signed-off-by: Andrew F. Davis <afd@ti.com>
That looks good to me overall, it should help with the randconfig warnings I've been seeing and makes the driver structured more logically.
The one part I wonder about is whether the platform_driver portion should also be split out into a separate module in the same way.
Arnd
| |