Messages in this thread | | | Date | Mon, 23 Nov 2015 16:13:39 +0100 | From | Matias Bjørling <> | Subject | Re: [PATCH] lightnvm: fix memory leak |
| |
On 11/23/2015 11:35 AM, Sudip Mukherjee wrote: > If copy_to_user() fails we returned error but we missed releasing > devices. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > drivers/lightnvm/core.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c > index f659e60..6688b60 100644 > --- a/drivers/lightnvm/core.c > +++ b/drivers/lightnvm/core.c > @@ -721,8 +721,11 @@ static long nvm_ioctl_get_devices(struct file *file, void __user *arg) > > devices->nr_devices = i; > > - if (copy_to_user(arg, devices, sizeof(struct nvm_ioctl_get_devices))) > + if (copy_to_user(arg, devices, > + sizeof(struct nvm_ioctl_get_devices))) { > + kfree(devices); > return -EFAULT; > + } > > kfree(devices); > return 0; >
Thanks Sudip, it seems like this error is in some of the others ioctl's as well. Do you want to send a patch with the fixes for them all?
| |