Messages in this thread | | | Date | Mon, 23 Nov 2015 13:37:42 +0100 | From | Jacek Anaszewski <> | Subject | Re: [PATCH] leds/powernv : removing NULL check |
| |
On 11/23/2015 10:28 AM, Saurabh Sengar wrote: > no need to explicitly check for pointer to be null, > of_prop_next_string anyways return NULL, if passed pointer is NULL > and hence loop will continue > > Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com> > --- > drivers/leds/leds-powernv.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/leds/leds-powernv.c b/drivers/leds/leds-powernv.c > index 1e75e1f..bc2d76e 100644 > --- a/drivers/leds/leds-powernv.c > +++ b/drivers/leds/leds-powernv.c > @@ -256,8 +256,6 @@ static int powernv_led_classdev(struct platform_device *pdev, > > for_each_child_of_node(led_node, np) { > p = of_find_property(np, "led-types", NULL); > - if (!p) > - continue; > > while ((cur = of_prop_next_string(p, cur)) != NULL) { > powernv_led = devm_kzalloc(dev, sizeof(*powernv_led), >
Applied, thanks.
-- Best Regards, Jacek Anaszewski
| |