lkml.org 
[lkml]   [2015]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1 6/7] test_hexdump: test all possible group sizes for overflow
Date
On Fri, Nov 20 2015, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Thu, 2015-11-19 at 11:14 +0100, Rasmus Villemoes wrote:
>>
>> aren't you missing a
>>
>>   test_hexdump_overflow(buflen, rounddown(len, gs), 32, gs, ascii);
>>
>> here to also exercise the rowsize==32 code?
>
> I could add that as well, though it seems minor since the idea is to go
> for all branches, which 16 covers anyway.

Well, I didn't look into the implementation when I wrote that; it just
seemed like an obvious thing to check all allowed combinations of
rowsize, groupsize and ascii.

>>  static int __init test_hexdump_init(void)
>> >  {
>> >   unsigned int i;
>> > @@ -186,10 +199,10 @@ static int __init test_hexdump_init(void)
>> >   test_hexdump_set(rowsize, true);
>> >  
>> >   for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++)
>> > - test_hexdump_overflow(i, false);
>> > + test_hexdump_overflow_set(i, false);
>> >  
>> >   for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++)
>> > - test_hexdump_overflow(i, true);
>> > + test_hexdump_overflow_set(i, true);
>>
>> It seems neater to do one loop:
>>
>> for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++) {
>>   test_hexdump_overflow_set(i, false);
>>   test_hexdump_overflow_set(i, true);
>> }
>
> I would like to keep them separately, though I'm also okay to do it in
> one loop.

Your code, your call.

Rasmus


\
 
 \ /
  Last update: 2015-11-23 11:01    [W:0.087 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site