Messages in this thread | | | Subject | Re: [PATCH] watchdog: mtk_wdt: Use MODE_KEY when stopping the watchdog | From | Matthias Brugger <> | Date | Fri, 20 Nov 2015 17:51:55 +0100 |
| |
On 18/11/15 17:24, Guenter Roeck wrote: > On 11/17/2015 06:45 PM, Nicolas Boichat wrote: >> WDT_MODE value need to be or-ed with MODE_KEY when setting >> watchdog mode. Add it to mtk_wdt_stop function, so that the >> watchdog can be stopped (e.g. during suspend). >> >> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
> >> --- >> drivers/watchdog/mtk_wdt.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c >> index 6ad9df9..b751f43 100644 >> --- a/drivers/watchdog/mtk_wdt.c >> +++ b/drivers/watchdog/mtk_wdt.c >> @@ -123,6 +123,7 @@ static int mtk_wdt_stop(struct watchdog_device >> *wdt_dev) >> >> reg = readl(wdt_base + WDT_MODE); >> reg &= ~WDT_MODE_EN; >> + reg |= WDT_MODE_KEY; >> iowrite32(reg, wdt_base + WDT_MODE); >> >> return 0; >> >
| |