Messages in this thread | | | Subject | Re: [PATCH V3 00/10] KVM: x86: MMU: Clean up x86's mmu code for future work | From | Paolo Bonzini <> | Date | Fri, 20 Nov 2015 17:01:18 +0100 |
| |
On 20/11/2015 09:40, Takuya Yoshikawa wrote: > About patch 03: There was a comment on the usage of braces for a single line > else-if statement from Xiao. As I answered, checkpatch did not complain about > this, and when the corresponding if block has multiple lines, some developers > prefer/recommend this style. Feel free to modify it if you don't like it.
I wonder if we can remove the "else if" completely. Will take a look after applying, early next week.
> For these three, I'm not sure what we should do now, still RFC? > We can also consider other approaches, e.g. moving link_shadow_page() in the > kvm_get_mmu_page() as Paolo suggested before.
I think I will include them in kvm/next.
Thanks,
Paolo
| |