Messages in this thread | | | Subject | Re: [PATCH] KVM: x86: emulate: correct page fault error code for NoWrite instructions | From | Nadav Amit <> | Date | Fri, 20 Nov 2015 09:46:07 +0200 |
| |
Wanpeng Li <kernellwp@gmail.com> wrote:
> 2015-11-20 10:52 GMT+08:00 Wanpeng Li <kernellwp@gmail.com>: >> Hi Paolo, >> 2015-02-09 17:03 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>: >>> NoWrite instructions (e.g. cmp or test) never set the "write access" >>> bit in the error code, even if one of the operands is treated as a >>> destination. >> >> Sorry to reply to an old commit, btw, could you point out where in SDM >> describe above? > > I see.
I don’t understand whether you still need my help, so to clarify: on a page-fault the error code should indicate whether the access was due to a write access. Previously KVM marked it as “write access” for instructions such as test and cmp that do not perform write.
Nadav
| |