lkml.org 
[lkml]   [2015]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval
From
Date
On 10/30/2015 01:45 PM, Arnd Bergmann wrote:
> On Friday 30 October 2015 12:58:33 Hannes Reinecke wrote:
>>> @@ -1076,7 +1069,7 @@ static int stex_ss_handshake(struct st_hba *hba)
>>> h->req_cnt = cpu_to_le16(hba->rq_count+1);
>>> h->status_sz = cpu_to_le16(sizeof(struct status_msg));
>>> h->status_cnt = cpu_to_le16(hba->sts_count+1);
>>> - stex_gettime(&h->hosttime);
>>> + h->hosttime = cpu_to_le64(ktime_get_real_seconds());
>>> h->partner_type = HMU_PARTNER_TYPE;
>>> h->extra_offset = h->extra_size = 0;
>>> scratch_size = (hba->sts_count+1)*sizeof(u32);
>>>
>> Just remove 'hosttime' altogether. It serves no purpose whatsoever.
>>
>>
>
> Are you sure? It is defined in a struct that is shared with the HBA
> as part of hba->dma_mem, so unless you have access to the firmware,
> it's hard to guess what it might be used for inside of the firmware.
>
Ah, you're right. Okay, so we'll need to convert it.

Cheers,

Hannes


\
 
 \ /
  Last update: 2015-11-02 09:01    [W:0.063 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site