Messages in this thread | | | Date | Mon, 2 Nov 2015 13:24:22 -0800 | From | Eduardo Valentin <> | Subject | Re: [PATCH] thermal: of: Introduce governor selection in dts |
| |
On Tue, Aug 11, 2015 at 10:07:31AM +0100, Sudeep Holla wrote: > > > On 10/08/15 18:47, Javi Merino wrote: > >On Mon, Aug 10, 2015 at 09:00:49AM +0100, Chung-Yih Wang (王崇懿) wrote: > >>This patch was originally introduced when we made power_allocator the > >>default governor where we had issues in binding a thermal zone w/o > >>parameters to. Then we came out this facility for binding a specific > >>governor to a thermal zone in dts instead of the default governor. > >>Javi seems like this idea much. > > > >While I can understand why this is not suitable for devicetree, we > >should have a way in the kernel to configure different governors for > >different thermal zones defined in device tree. Thermal zones defined > >from platform code can choose the thermal governor when they are > >registered. > > > >If this information can't go in device tree, where can we put it? As > >an additional parameter to thermal_zone_of_sensor_register()? > > > > Why can't it be via sysfs allowing users to select their choice of > governor ? (like cpuidle/freq or even devfreq I assume) >
Yes, sysfs configuration is the current recommended way.
Although it is tempting to have it in device tree, its design decisions are not meant for OS implementation/specifics.
BR,
> Regards, > Sudeep
| |