Messages in this thread | | | Date | Mon, 2 Nov 2015 16:29:06 +0100 | From | Thomas Petazzoni <> | Subject | Re: [PATCH v7 2/7] dmaengine: mxs: APBH DMA supports deep sleep mode |
| |
Vinod,
On Sat, 31 Oct 2015 07:12:44 +0530, Vinod Koul wrote: > On Tue, Oct 27, 2015 at 05:05:35PM -0500, Han Xu wrote: > > > > -static int __init mxs_dma_init(struct mxs_dma_engine *mxs_dma) > > +static int mxs_dma_init(struct mxs_dma_engine *mxs_dma) > > This change seems unrelated to patch description, can you explain why?
It seems related: mxs_dma_init() is now no longer called at initialization time, but also when resuming, as visible...
> > > +#ifdef CONFIG_PM_SLEEP > > +static int mxs_dma_pm_resume(struct device *dev) > > +{ > > + struct mxs_dma_engine *mxs_dma = dev_get_drvdata(dev); > > + int ret; > > + > > + ret = mxs_dma_init(mxs_dma);
... here.
Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
| |