Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails | Date | Mon, 02 Nov 2015 09:58:30 -0500 |
| |
Jens Axboe <axboe@kernel.dk> writes:
> On 10/30/2015 09:34 AM, Jeff Moyer wrote: >> From: Vivek Goyal <vgoyal@redhat.com> >> >> If a block device is hot removed and later last reference to device >> is put, we try to writeback the dirty inode. But device is gone and >> that writeback fails. >> >> Currently we do a WARN_ON() which does not seem to be the right thing. >> Convert it to a ratelimited kernel warning. > > Any concerns with putting this into 4.4 and marking it for stable?
No, that sounds fine to me.
> Would be awesome to have a "Fixes:" in here too.
OK. I don't know which commit introduced the problem. Do you want something like this?
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1196089 or Fixes: https://www.redhat.com/archives/dm-devel/2015-June/msg00111.html
I know some folks don't like mailing list archive links in the commit messages.
Cheers, Jeff
| |