Messages in this thread | | | Date | Wed, 18 Nov 2015 09:26:54 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder |
| |
On Wed, Nov 18, 2015 at 02:41:14PM +0900, Namhyung Kim wrote:
SNIP
> > I think callchain value being 0 is an error or marker for the end of > callchain. So it'd be better avoiding 0 entry. > > But unfortunately, we have many 0 entries (and broken callchain after > them) with fp recording on optimized binaries. I think we should omit > those callchains. > > Maybe something like this? > > > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index 5ef90be2a249..22642c5719ab 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -1850,6 +1850,15 @@ static int thread__resolve_callchain_sample(struct thread *thread, > #endif > ip = chain->ips[j]; > > + /* callchain value inside zero page means it's broken, stop */ > + if (ip < 4096) {
you could use page_size in here
jirka
| |