lkml.org 
[lkml]   [2015]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support
    Date

    Hi,

    Arnd Bergmann <arnd@arndb.de> writes:
    > On Wednesday 18 November 2015 12:29:27 Bin Liu wrote:
    >> > diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
    >> > index 1f2037bbeb0d..45c83baf675d 100644
    >> > --- a/drivers/usb/musb/Kconfig
    >> > +++ b/drivers/usb/musb/Kconfig
    >> > @@ -159,7 +159,7 @@ config USB_TI_CPPI_DMA
    >> >
    >> > config USB_TI_CPPI41_DMA
    >> > bool 'TI CPPI 4.1 (AM335x)'
    >> > - depends on ARCH_OMAP
    >> > + depends on ARCH_OMAP && DMADEVICES
    >> > select TI_CPPI41
    >>
    >> I am not sure what the generic policy is, but instead of hiding
    >> USB_TI_CPPI41_DMA if DMADEVICES is disabled, I'd like to enable
    >> DMADEVICES if USB_TI_CPPI41_DMA is enabled, from user experience
    >> perspective.
    >
    > General policy is that you should not 'select' a symbol that is
    > also user-visible, as that tends to cause dependency loops and
    > other problems when something is enabled without the user being
    > aware of that.
    >
    > Ideally we should remove the 'select TI_CPPI41' here as well, but
    > what we could do instead is to make that a silent symbol and remove
    > the prompt so it always gets enabled implicitly when USB_TI_CPPI41_DMA
    > and DMADEVICES are both enabled.

    that should be perfect now that Tony L fixed this up so we can enable
    all MUSB DMA Engines in a single zImage.

    --
    balbi
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2015-11-18 22:01    [W:2.610 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site