lkml.org 
[lkml]   [2015]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] keys, trusted: seal with a policy
On Tue, 17 Nov 2015, Jarkko Sakkinen wrote:

> }
> break;
> + case Opt_policydigest:
> + if (!tpm2 ||
> + strlen(args[0].from) != (2 * opt->digest_len))
> + return -EINVAL;
> + kfree(opt->policydigest);
> + opt->policydigest = kzalloc(opt->digest_len,
> + GFP_KERNEL);

Is it correct to kfree opt->policydigest here before allocating it?


> + if (!opt->policydigest)
> + return -ENOMEM;
> + res = hex2bin(opt->policydigest, args[0].from,
> + opt->digest_len);
> + if (res < 0)
> + return -EINVAL;

Do you need to kfree it here on error?

--
James Morris
<jmorris@namei.org>



\
 
 \ /
  Last update: 2015-11-18 01:41    [W:0.113 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site