lkml.org 
[lkml]   [2015]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] net-scm: Delete an unnecessary check before the function call "kfree"
    From
    From: SF Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 17 Nov 2015 17:43:35 +0100

    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Tue, 17 Nov 2015 17:37:22 +0100
    >
    > The kfree() function tests whether its argument is NULL and then
    > returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

    STOP submitting this crap, NOW!

    I told you I won't review nor apply these patches any more.

    And ever worse, this one is BUGGY.

    We're testing p->fp so we know if we can safely dereference
    it or not.

    You're adding an OOPS to the kernel.

    This is why these mindless mechanical transformations are not
    only often a waste of time, they are dangerous as well.

    I am silently rejecting from patchwork, immediately, any and all
    patches you submit of this nature.


    \
     
     \ /
      Last update: 2015-11-17 18:21    [W:4.014 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site