lkml.org 
[lkml]   [2015]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] net-scm: Delete an unnecessary check before the function call "kfree"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 17 Nov 2015 17:37:22 +0100

    The kfree() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    net/core/scm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/core/scm.c b/net/core/scm.c
    index 3b6899b..4f64173 100644
    --- a/net/core/scm.c
    +++ b/net/core/scm.c
    @@ -193,7 +193,7 @@ int __scm_send(struct socket *sock, struct msghdr *msg, struct scm_cookie *p)
    }
    }

    - if (p->fp && !p->fp->count)
    + if (likely(!p->fp->count))
    {
    kfree(p->fp);
    p->fp = NULL;
    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-17 18:01    [W:4.019 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site