Messages in this thread | | | Subject | Re: [PATCH v7,1/3] dt-bindings: binding for jz4780-{nand,bch} | From | Harvey Hunt <> | Date | Tue, 17 Nov 2015 16:08:32 +0000 |
| |
Hi Boris,
On 04/11/15 07:57, Boris Brezillon wrote: > Hi Harvey, > > On Tue, 6 Oct 2015 17:27:15 +0100 > Harvey Hunt <harvey.hunt@imgtec.com> wrote: > >> From: Alex Smith <alex.smith@imgtec.com> >> >> Add DT bindings for NAND devices connected to the NEMC on JZ4780 SoCs, >> as well as the hardware BCH controller, used by the jz4780_{nand,bch} >> drivers. > > Patch 3 does not seem to follow this binding: it still uses the > ingenic,ecc-xxx properties and defines NAND timings.
I'll fix this for v8.
> Also, as answered to patch 3, I think it would be clearer to separate > the nand controller and nand chip representation.
I agree - I'll implement this in the next version.
> Best Regards, > > Boris
Thanks,
Harvey Hunt
| |