Messages in this thread | | | Subject | Re: [PATCH 1/3] mtd: m25p80: fix module autoloading for "jedec,spi-nor" and "spi-nor" | From | Javier Martinez Canillas <> | Date | Tue, 17 Nov 2015 10:55:04 -0300 |
| |
Hello Brian,
On 11/16/2015 07:34 PM, Brian Norris wrote: > Commit 43163022927b ("mtd: m25p80: allow arbitrary OF matching for > "jedec,spi-nor"") moved the "jedec,spi-nor" handling from the > spi_device_id table to the of_match_table, to better handle matching > complex device tree compatible strings. With that patch, device tree > support works as expected when m25p80.c is built into the kernel. > > However, that commit ignored the fact that: > > (1) (non-DT) platform devices might want to use the "spi-nor" string > for matching with this driver, rather than picking an arbitrary one > like "m25p80" > (2) the core SPI uevent/modalias code doesn't yet support kernel module > autoloading via of_match_table strings; so for DT-based devices, it > will only report (part of) the first compatible string used >
Very nice changelog message!
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
| |