Messages in this thread | | | Subject | Re: [PATCH] clocksource/drivers/tango-xtal: Replace code by clocksource_mmio_init | From | Daniel Lezcano <> | Date | Tue, 17 Nov 2015 13:22:52 +0100 |
| |
On 11/13/2015 01:20 PM, Marc Gonzalez wrote: > On 13/11/2015 11:58, Daniel Lezcano wrote: > >> The current code to initialize, register and read the clocksource is >> already factored out in mmio.c via the clocksource_mmio_init function. >> >> Factor out the code with the clocksource_mmio_init function. > > The reason I didn't like clocksource_mmio_init() is because it exports > 4 generic accessors. > > I guess this function makes more sense when all platforms are using it, > in an ARCH_MULTIPLATFORM kernel. (Also the accessors are probably quite > small, so the waste is probably minimal.)
Hi Marc,
it is not clear for me if you agree with this patch or not. Can you clarify ?
Thanks
-- Daniel
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |