Messages in this thread | | | Date | Tue, 17 Nov 2015 11:04:17 +0100 | Subject | Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs | From | Geert Uytterhoeven <> |
| |
On Tue, Nov 17, 2015 at 10:02 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Fri, Nov 13, 2015 at 1:26 AM, Florian Fainelli <f.fainelli@gmail.com> wrote: >> On 04/11/15 18:56, David Miller wrote: >>>> Fixes: fd867d51f889 ("net/core: generic support for disabling netdev features down stack") >>> ... >>>> Reported-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> >>>> Signed-off-by: Jarod Wilson <jarod@redhat.com> >>>> --- >>>> v2: Based on suggestions from Alex, and with not changing err to ret, this >>>> patch actually becomes quite minimal and doesn't ugly up the code much. >>> >>> Applied, thanks. >> >> This causes some warnings to be displayed for DSA stacked devices: > > And a few more: > > sh-eth ee700000.ethernet eth0: set_features() failed (-1); wanted > 0x0000000000004000, left 0x0000000000004800 > g_ether gadget usb0: set_features() failed (-1); wanted > 0x0000000000004000, left 0x0000000000004800
smsc911x 8000000.ethernet eth0: set_features() failed (-1); wanted 0x0000000000004000, left 0x0000000000004800
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |