lkml.org 
[lkml]   [2015]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/7] mm/vmscan: page_is_file_cache can be boolean
    On Mon, 16 Nov 2015, Yaowei Bai wrote:

    > diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h
    > index cf55945..af73135 100644
    > --- a/include/linux/mm_inline.h
    > +++ b/include/linux/mm_inline.h
    > @@ -8,8 +8,8 @@
    > * page_is_file_cache - should the page be on a file LRU or anon LRU?
    > * @page: the page to test
    > *
    > - * Returns 1 if @page is page cache page backed by a regular filesystem,
    > - * or 0 if @page is anonymous, tmpfs or otherwise ram or swap backed.
    > + * Returns true if @page is page cache page backed by a regular filesystem,
    > + * or false if @page is anonymous, tmpfs or otherwise ram or swap backed.
    > * Used by functions that manipulate the LRU lists, to sort a page
    > * onto the right LRU list.
    > *
    > @@ -17,7 +17,7 @@
    > * needs to survive until the page is last deleted from the LRU, which
    > * could be as far down as __page_cache_release.
    > */
    > -static inline int page_is_file_cache(struct page *page)
    > +static inline bool page_is_file_cache(struct page *page)
    > {
    > return !PageSwapBacked(page);
    > }

    Since page_is_file_cache() is often used to determine which zlc to
    increment or decrement (usage such as
    NR_ISOLATED_ANON + page_is_file_cache(page)), I don't think this style is
    helpful.


    \
     
     \ /
      Last update: 2015-11-16 11:21    [W:5.107 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site