Messages in this thread | | | Subject | Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of failed kmalloc() | From | "Nicholas A. Bellinger" <> | Date | Sat, 14 Nov 2015 14:31:13 -0800 |
| |
Hi Luis,
Apologies for the delayed response.
On Mon, 2015-10-19 at 21:18 +0100, Luis de Bethencourt wrote: > Smatch complains about returning hard coded error codes, silence this > warning. > > drivers/target/iscsi/iscsi_target_parameters.c:211 iscsi_create_default_params() warn: returning -1 instead of -ENOMEM is sloppy > > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> > --- > > Hi, > > This doesn't change the functionality. It is just about using the more specific > errno. And at the same time silencing smatch. > > Thanks, > Luis > > drivers/target/iscsi/iscsi_target_parameters.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >
Applied to target-pending/queue-fixes.
Thank you,
--nab
| |