lkml.org 
[lkml]   [2015]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] Bluetooth-cmtp: Delete an unnecessary check before the function call "kfree_skb"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 14 Nov 2015 22:00:27 +0100

    The kfree_skb() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    net/bluetooth/cmtp/core.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/net/bluetooth/cmtp/core.c b/net/bluetooth/cmtp/core.c
    index 298ed37..9e59b66 100644
    --- a/net/bluetooth/cmtp/core.c
    +++ b/net/bluetooth/cmtp/core.c
    @@ -178,8 +178,7 @@ static inline int cmtp_recv_frame(struct cmtp_session *session, struct sk_buff *
    cmtp_add_msgpart(session, id, skb->data + hdrlen, len);
    break;
    default:
    - if (session->reassembly[id] != NULL)
    - kfree_skb(session->reassembly[id]);
    + kfree_skb(session->reassembly[id]);
    session->reassembly[id] = NULL;
    break;
    }
    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-14 22:41    [W:4.020 / U:0.484 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site