Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH 1/4] loop: Enable correct physical blocksize | Date | Fri, 13 Nov 2015 15:57:33 -0500 |
| |
Hi Hannes,
Hannes Reinecke <hare@suse.de> writes:
> When running on files the physical blocksize is actually 4k,
How did you come to that conclusion? Are you basing it on the file system block size? If so, that's configurable at mkfs time and can be anything from 512 bytes to 64k on current in-tree file systems that I know of (depending on platform, of course).
The main use for physical block size, as I understand it, is to allow partitioning utilities to place partitions on physical block boundaries of the underlying storage. The benefit of that is to avoid read-modify-writes for I/O which is naturally sized and aligned. If we carry that forward to loop, then I think it does makes sense to key off of the file system block size, but the fact remains that 4k is not universal.
So, I think the idea is sound, but you should be setting the physical block size to sb->s_blocksize. And I don't see any reason why we wouldn't do this by default, do you?
If you end up reposting this patch, would you mind including more of this rationale in your commit message?
Thanks! Jeff
| |