lkml.org 
[lkml]   [2015]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V3 02/26] coresight: etm3x: moving sysFS entries to dedicated file
Date
On Friday 13 November 2015 09:17:18 Mathieu Poirier wrote:
> On 11 November 2015 at 15:30, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Wednesday 11 November 2015 15:17:52 Mathieu Poirier wrote:
> >> SysFS entries are big enough to justify their own file.
> >> As such moving all sysFS related declarations to a dedicated
> >> location.
> >>
> >> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> >> ---
> >> drivers/hwtracing/coresight/Makefile | 3 +-
> >> drivers/hwtracing/coresight/coresight-etm.h | 4 +
> >> .../hwtracing/coresight/coresight-etm3x-sysfs.c | 1218 +++++++++++++++++++
> >> drivers/hwtracing/coresight/coresight-etm3x.c | 1234 +-------------------
> >>
> >
> > You are adding a lot of interfaces here, make sure that each one is documented
> > in Documentation/ABI/.
>
> Everything is documented in
> Documentation/ABI/testing/sysfs-bus-coresight-devices-etm3x.
>
> >
> > Your patch series doesn't add anything here, are you just using an existing
> > ABI?
>
> That is correct.

Ok, excellent. I failed to see that all the implementations are just moved
from one file to another, should really have read the patch description better.

Arnd


\
 
 \ /
  Last update: 2015-11-13 17:41    [W:0.065 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site