lkml.org 
[lkml]   [2015]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4 v5] livepatch: Simplify code for relocated external symbols
On Fri 2015-11-13 11:24:33, Miroslav Benes wrote:
> On Thu, 12 Nov 2015, Chris J Arges wrote:
>
> > From: Petr Mladek <pmladek@suse.com>
> >
> > The livepatch module might be linked from several .o files.
> > All symbols that need to be shared between these .o files
> > should be exported. This is a normal programming practice.
> > I do not see any reason to access static symbols between
> > these .o files.
> >
> > This patch removes the search for the static symbols within
> > the livepatch module. It makes it easier to understand
> > the meaning of the external flag and klp_find_external_symbol()
> > function.
> >
> > Signed-off-by: Petr Mladek <pmladek@suse.com>
> > Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
>
> I'd remove this patch from the patch set, because
>
> 1. Josh needs to confirm that it is possible for kpatch to live without
> external or that we can modify it. This could postpone this patch set as a
> whole.
>
> 2. I think the issue is quite independent of the problem this patch set
> solves.
>
> 3. I can even imagine that we could get rid of 'external' in klp_func and
> its special handling completely if kpatch allows.
>
> So let's solve it separately. Does anyone have a different opinion?

I agree. Let's solve this separately and leave it out for now.

Best Regards,
Petr


\
 
 \ /
  Last update: 2015-11-13 15:01    [W:0.031 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site