lkml.org 
[lkml]   [2015]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] net: phy: vitesse: add support for VSC8601
Date
Mason <slash.tmp@free.fr> writes:

> On 12/11/2015 19:41, Mans Rullgard wrote:
>
>> + .phy_id = PHY_ID_VSC8601,
>> + .name = "Vitesse VSC8601",
>> + .phy_id_mask = 0x000ffff0,
>> + .features = PHY_GBIT_FEATURES,
>> + .flags = PHY_HAS_INTERRUPT,
>> + .config_init = &genphy_config_init,
>> + .config_aneg = &genphy_config_aneg,
>> + .read_status = &genphy_read_status,
>> + .ack_interrupt = &vsc824x_ack_interrupt,
>> + .config_intr = &vsc82xx_config_intr,
>
> I expected Documentation/CodingStyle to forbid taking the address
> of functions.

I can't find anything to that effect. That said, it's not something I
would normally do, but all the other phy_driver entries in that file
look like that.

--
Måns Rullgård
mans@mansr.com


\
 
 \ /
  Last update: 2015-11-13 11:21    [W:0.068 / U:2.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site