lkml.org 
[lkml]   [2015]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/mm: fix regression with huge pages on PAE

* Kirill A. Shutemov <kirill@shutemov.name> wrote:

> On Thu, Nov 12, 2015 at 08:48:54AM +0100, Ingo Molnar wrote:
> >
> > * Borislav Petkov <bp@alien8.de> wrote:
> >
> > > --- a/arch/x86/include/asm/pgtable_types.h
> > > +++ b/arch/x86/include/asm/pgtable_types.h
> > > @@ -279,17 +279,14 @@ static inline pmdval_t native_pmd_val(pmd_t pmd)
> > > static inline pudval_t pud_pfn_mask(pud_t pud)
> > > {
> > > if (native_pud_val(pud) & _PAGE_PSE)
> > > - return PUD_PAGE_MASK & PHYSICAL_PAGE_MASK;
> > > + return ~((1ULL << PUD_SHIFT) - 1) & PHYSICAL_PAGE_MASK;
> > > else
> > > return PTE_PFN_MASK;
> > > }
> >
> > > static inline pmdval_t pmd_pfn_mask(pmd_t pmd)
> > > {
> > > if (native_pmd_val(pmd) & _PAGE_PSE)
> > > - return PMD_PAGE_MASK & PHYSICAL_PAGE_MASK;
> > > + return ~((1ULL << PMD_SHIFT) - 1) & PHYSICAL_PAGE_MASK;
> > > else
> > > return PTE_PFN_MASK;
> > > }
> >
> > So instead of uglifying the code, why not fix the real bug: change the
> > PMD_PAGE_MASK/PUD_PAGE_MASK definitions to be 64-bit everywhere?
>
> *PAGE_MASK are usually applied to virtual addresses. I don't think it
> should anything but 'unsigned long'. This is odd use case really.

So we already have PHYSICAL_PAGE_MASK, why not introduce PHYSICAL_PMD_MASK et al,
instead of uglifying the code?

But, what problems do you expect with having a wider mask than its primary usage?
If it's used for 32-bit values it will be truncated down safely. (But I have not
tested it, so I might be missing some complication.)

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-11-12 09:21    [W:0.090 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site