lkml.org 
[lkml]   [2015]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] null_blk: Register as a LightNVM device
From
Date
On 11/12/2015 01:53 AM, Christoph Hellwig wrote:
> On Wed, Nov 11, 2015 at 11:06:38AM +0100, Matias Bj??rling wrote:
>> Add support for registering as a LightNVM device. This allows us to
>> evaluate the performance of the LightNVM library.
>>
>> In /drivers/Makefile, LightNVM is moved above block device drivers
>> to make sure that the LightNVM media managers have been initialized
>> before drivers under /drivers/block are initialized.
>
> I don't think mixing the lighnvm code into null_blk is a good idea.
> Please just create a separate null_nvm device for lighnvm. It already
> has a completely separate I/O path.

But it still avoids duplicating the generics of it. Patch for null_blk:

3 files changed, 168 insertions(+), 7 deletions (-)

vs a standalone of:

3 files changed, 459 insertions(+)

It doesn't screw up null_blk, so I'd prefer just adding it as an
on-the-side mode for that.

--
Jens Axboe



\
 
 \ /
  Last update: 2015-11-12 17:01    [W:0.247 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site