Messages in this thread | | | Date | Thu, 12 Nov 2015 20:24:28 +0800 | From | Jisheng Zhang <> | Subject | Re: [PATCH] PCI: hisi: Fix Section mismatch compilation warning for probe() |
| |
On Thu, 12 Nov 2015 13:21:02 +0100 Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 12 November 2015 20:02:08 Jisheng Zhang wrote: > > Following compilation warning occurs when compiled with: > > CONFIG_DEBUG_SECTION_MISMATCH=y > > > > WARNING: drivers/pci/host/built-in.o(.data+0x308): Section mismatch in > > reference from the variable hisi_pcie_driver to the function > > .init.text:hisi_pcie_probe() > > > > Fix it by dropping __init from hisi_pcie_probe(). > > The patch description should ideally say what the impact is here, not > only what the warning says. > > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > > Fixes: 500a1d9a43e0 ("PCI: hisi: Add HiSilicon SoC Hip05 PCIe driver") > > --- > > drivers/pci/host/pcie-hisi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/host/pcie-hisi.c b/drivers/pci/host/pcie-hisi.c > > index 35457ec..1cc0a21 100644 > > --- a/drivers/pci/host/pcie-hisi.c > > +++ b/drivers/pci/host/pcie-hisi.c > > @@ -139,7 +139,7 @@ static int __init hisi_add_pcie_port(struct pcie_port *pp, > > return 0; > > } > > > > -static int __init hisi_pcie_probe(struct platform_device *pdev) > > +static int hisi_pcie_probe(struct platform_device *pdev) > > { > > struct hisi_pcie *hisi_pcie; > > struct pcie_port *pp; > > This seems incomplete, you now get a new warning about hisi_add_pcie_port().
oops, yes. Thanks.
> > I did a similar patch yesterday, will follow up with my version.
Your version is completed.
Thanks, Jisheng
| |