Messages in this thread | | | Date | Wed, 11 Nov 2015 11:38:46 -0800 | From | "Luck, Tony" <> | Subject | Re: [PATCH] Cleanup useless codes in CMCI handler |
| |
On Wed, Nov 11, 2015 at 10:16:45AM -0500, Chen, Gong wrote: > UCNA errors share the same handler with CMCI. But it doesn't > need extra operation to save error record in genpool. Remove > these uselss codes.
I'd have emphasised that this same mce is being added to the genpool *twice* (once here, and again when we call mce_log() just below).
Though there may be some corner cases depending on flags and mca_cfg.dont_log_ce
-Tony
> > Signed-off-by: Chen, Gong <gong.chen@linux.intel.com> > --- > arch/x86/kernel/cpu/mcheck/mce.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c > index c5b0d562dbf5..1ad3fb4f99b7 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce.c > +++ b/arch/x86/kernel/cpu/mcheck/mce.c > @@ -609,20 +609,6 @@ bool machine_check_poll(enum mcp_flags flags, mce_banks_t *b) > severity = mce_severity(&m, mca_cfg.tolerant, NULL, false); > > /* > - * In the cases where we don't have a valid address after all, > - * do not add it into the ring buffer. > - */ > - if (severity == MCE_DEFERRED_SEVERITY && memory_error(&m)) { > - if (m.status & MCI_STATUS_ADDRV) { > - m.severity = severity; > - m.usable_addr = mce_usable_address(&m); > - > - if (!mce_gen_pool_add(&m)) > - mce_schedule_work(); > - } > - } > - > - /* > * Don't get the IP here because it's unlikely to > * have anything to do with the actual error location. > */ > -- > 2.3.2 >
| |