Messages in this thread | | | Date | Wed, 11 Nov 2015 16:42:49 +0100 | From | Petr Mladek <> | Subject | Re: [RFC PATCH 4/5] samples: livepatch: init reloc list and mark as klp module |
| |
On Mon 2015-11-09 23:45:54, Jessica Yu wrote: > Intialize the list of relocation sections in the sample > klp_object (even if the list will be empty in this case). > Also mark module as a livepatch module so that the module > loader can appropriately initialize it. > > Signed-off-by: Jessica Yu <jeyu@redhat.com> > --- > samples/livepatch/livepatch-sample.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/samples/livepatch/livepatch-sample.c b/samples/livepatch/livepatch-sample.c > index fb8c861..2ef9345 100644 > --- a/samples/livepatch/livepatch-sample.c > +++ b/samples/livepatch/livepatch-sample.c > @@ -89,3 +90,4 @@ static void livepatch_exit(void) > module_init(livepatch_init); > module_exit(livepatch_exit); > MODULE_LICENSE("GPL"); > +MODULE_INFO(livepatch, "Y");
This looks a bit error prone. I wonder if we could detect this information another way. For example, by a check for the livepatch-related elf sections. If it is missing, we do not need to preserve struct load_info even when it is a livepatch.
Best Regards, Petr
| |