lkml.org 
[lkml]   [2015]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device
On Wed, 11 Nov 2015, Lu Baolu wrote:

> Commit 8306095fd2c1 ("USB: Disable USB 3.0 LPM in critical sections.")
> adds usb3_lpm_enabled member to struct usb_device. There is no reference
> to this member now. Hence, it could be removed.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
> include/linux/usb.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/usb.h b/include/linux/usb.h
> index 211664f..036e4a5 100644
> --- a/include/linux/usb.h
> +++ b/include/linux/usb.h
> @@ -583,7 +583,6 @@ struct usb_device {
> unsigned usb2_hw_lpm_besl_capable:1;
> unsigned usb2_hw_lpm_enabled:1;
> unsigned usb2_hw_lpm_allowed:1;
> - unsigned usb3_lpm_enabled:1;
> unsigned usb3_lpm_u1_enabled:1;
> unsigned usb3_lpm_u2_enabled:1;
> int string_langid;

You forgot to remove the kerneldoc for this field. And you forgot to
add kerneldoc for usb3_lpm_u[12]_enabled.

Alan Stern



\
 
 \ /
  Last update: 2015-11-11 16:21    [W:0.106 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site