Messages in this thread | | | Subject | Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller | From | Eric Dumazet <> | Date | Tue, 10 Nov 2015 13:51:20 -0800 |
| |
On Tue, 2015-11-10 at 21:21 +0000, Måns Rullgård wrote:
> Even ixgbe uses napi_complete() while netdevice.h says one should > "consider using napi_complete_done() instead." Did the author consider > it and decide not to, or has the driver simply not been updated?
napi_complete_done() is quite new, very few drivers use it.
It still requires a tuning (/sys/class/net/ethX/gro_flush_timeout)
> > As for the napi_gro_receive() function, calling that instead of > netif_receive_skb() is easy enough, or are there other things I should > be doing in addition?
Nothing comes to mind, if you already have a NAPI context, napi_gro_receive() is the way to go...
| |