Messages in this thread | | | Date | Tue, 10 Nov 2015 10:05:04 -0800 | Subject | Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. | From | Dan Williams <> |
| |
On Tue, Nov 10, 2015 at 9:51 AM, Jeff Moyer <jmoyer@redhat.com> wrote: > Jerry Hoemann <jerry.hoemann@hpe.com> writes: > >> Add IOCTL type 'P' to denote NVDIMM_TYPE_PASSTHRU. > > Can't you just make passthrough a separate command? If you actually add > the ioctl definition for passthrough (which you didn't do for some > reason?), it looks odd: > > #define ND_IOCTL_PASSTHRU _IOWR(NVDIMM_TYPE_PASSTHRU,, ND_CMD_PASSTHRU, \ > struct ndn_package) > > Care to comment on why you chose a different type instead of specifying > a new command?
+1 for making this just a new command number without a new top-level number space.
| |