Messages in this thread | | | Date | Sun, 1 Nov 2015 11:58:01 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v9 1/1] efi: a misc char interface for user to update efi firmware |
| |
On Sun, Nov 01, 2015 at 10:52:52AM +0000, Kweh, Hock Leong wrote: > Could you share me your dumb file? I did perform negative test, but I did > not get these dump stack in dmesg. Thanks.
I think almost any file works:
cat /bin/ls > /dev/efi_capsule_loader
> > > +#define UPLOAD_DONE -1 > > > > Isn't the fact that upload was finished a success message? If so, why is it a > > negative value? > > This is to indicate an upload is done and pending for close(2). If a subsequence > write(2) perform, return error. Comments inputted by Matt and Andy.
But in that case you can return ERR_OCCURRED. UPLOAD_DONE still doesn't look like a negative value to me as it signals that the upload was done and thus successful as no errors happened during the upload.
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
| |