lkml.org 
[lkml]   [2015]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: smsc911x: Reset PHY during initialization
From
From: Pavel Fedin <p.fedin@samsung.com>
Date: Fri, 30 Oct 2015 10:06:19 +0300

> On certain hardware after software reboot the chip may get stuck and fail
> to reinitialize during reset. This can be fixed by ensuring that PHY is
> reset too.
>
> Old PHY resetting method required operational MDIO interface, therefore
> the chip should have been already set up. In order to be able to function
> during probe, it is changed to use PMT_CTRL register.
>
> The problem could be observed on SMDK5410 board.
>
> Signed-off-by: Pavel Fedin <p.fedin@samsung.com>

I'm pretty sure this is going to break the PHY loopback test.

This is such a tricky and fragile area to get right, therefore I
want you to specifically guard any change in how PHY reset is
done with tests against the specific chips that have the problem.

Furthermore, I want you to test whether this has any negative
effects on the PHY loopback test.


\
 
 \ /
  Last update: 2015-11-01 23:01    [W:0.029 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site