lkml.org 
[lkml]   [2015]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] NET: ATM: MPOA: Remove 32-bit timekeeping
From
From: Tina Ruchandani <ruchandani.tina@gmail.com>
Date: Thu, 29 Oct 2015 22:01:07 -0700

> @@ -14,9 +15,9 @@ void atm_mpoa_init_cache(struct mpoa_client *mpc);
> typedef struct in_cache_entry {
> struct in_cache_entry *next;
> struct in_cache_entry *prev;
> - struct timeval tv;
> - struct timeval reply_wait;
> - struct timeval hold_down;
> + time64_t tv;
> + time64_t reply_wait;
> + time64_t hold_down;
> uint32_t packets_fwded;
> uint16_t entry_state;
> uint32_t retry_time;
> @@ -51,7 +52,7 @@ struct in_cache_ops{
> typedef struct eg_cache_entry{
> struct eg_cache_entry *next;
> struct eg_cache_entry *prev;
> - struct timeval tv;
> + time64_t tv;

Again, these structure member names like "tv" only make sense if
they store a "timeval". Please rename these structure members
appropriately, thanks.


\
 
 \ /
  Last update: 2015-11-01 22:41    [W:0.052 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site